Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

test: Rewrite SampleRowKeys IT on AuthorizedView#2187

Merged
mutianf merged 2 commits into
googleapis:mainfrom
trollyxia:it
Mar 28, 2024
Merged

test: Rewrite SampleRowKeys IT on AuthorizedView#2187
mutianf merged 2 commits into
googleapis:mainfrom
trollyxia:it

Conversation

@trollyxia
Copy link
Copy Markdown
Contributor

Change-Id: I37927d1b0a3502f6554e575ac44d4d92417d7d26

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@trollyxia trollyxia requested review from a team March 28, 2024 13:46
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 28, 2024
@mutianf
Copy link
Copy Markdown
Contributor

mutianf commented Mar 28, 2024

lgtm but please reformat the code with mvn com.coveo:fmt-maven-plugin:format

Change-Id: I37927d1b0a3502f6554e575ac44d4d92417d7d26
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2024
@trollyxia trollyxia requested a review from a team March 28, 2024 14:30
@mutianf mutianf merged commit 3ccd8fc into googleapis:main Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants