Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

chore: fork ChannelPool and ChannelPoolSettings into gaxx/grpc#2496

Merged
gcf-merge-on-green[bot] merged 3 commits into
googleapis:mainfrom
nicholsl:channel-pool-fork
May 12, 2025
Merged

chore: fork ChannelPool and ChannelPoolSettings into gaxx/grpc#2496
gcf-merge-on-green[bot] merged 3 commits into
googleapis:mainfrom
nicholsl:channel-pool-fork

Conversation

@nicholsl
Copy link
Copy Markdown
Contributor

@nicholsl nicholsl commented Feb 28, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - Fork ChannelPool and ChannelPoolSettings into cloud/bigtable/gaxx #2495
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary) (N/A)
  • Rollback plan is reviewed and LGTMed (N/A)
  • All new data plane features have a completed end to end testing plan (N/A)

Fixes #2495 ☕️

If you write sample code, please follow the samples format.

@nicholsl nicholsl requested review from a team February 28, 2025 02:48
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Feb 28, 2025
@nicholsl nicholsl changed the title Fork ChannelPool and ChannelPoolSettings into gaxx/grpc feat: fork ChannelPool and ChannelPoolSettings into gaxx/grpc Feb 28, 2025
@nicholsl nicholsl force-pushed the channel-pool-fork branch from 2bdecaf to 91fe036 Compare May 9, 2025 20:32
@mutianf mutianf changed the title feat: fork ChannelPool and ChannelPoolSettings into gaxx/grpc chore: fork ChannelPool and ChannelPoolSettings into gaxx/grpc May 12, 2025
@mutianf
Copy link
Copy Markdown
Contributor

mutianf commented May 12, 2025

/gcbrun

@mutianf mutianf added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels May 12, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 12, 2025
@nicholsl
lint
3fadaee 
Change-Id: I6a9f656edf9d941a09bd364042c82f2314ddd668
@mutianf mutianf added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 12, 2025
@mutianf
Copy link
Copy Markdown
Contributor

mutianf commented May 12, 2025

/gcbrun

@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 12, 2025
@gcf-merge-on-green gcf-merge-on-green Bot merged commit ea19c85 into googleapis:main May 12, 2025
22 checks passed
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mutianf mutianf mutianf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fork ChannelPool and ChannelPoolSettings into cloud/bigtable/gaxx

3 participants

@nicholsl @mutianf @yoshi-kokoro