This repository was archived by the owner on May 8, 2026. It is now read-only.
feat(bigtable): Add integration tests for Materialized/Logical Views#2518
Merged
Conversation
| } | ||
|
|
||
| @Test | ||
| public void materializedViewTest() { |
Contributor
There was a problem hiding this comment.
Can we be a bit more descriptive in what we are testing? e.g. createUpdateAndDeleteMaterializedView
Contributor
There was a problem hiding this comment.
Also can we split these up so that when tests fail it is easier to see what failed
Contributor
There was a problem hiding this comment.
These should not be on tests for InstanceAdmin. We should probably either create a new suite or use BigtableTableAdminClientIT.java (I prefer we added a new test suite)
Contributor
There was a problem hiding this comment.
ty! I think we can revert this file now?
Contributor
Author
There was a problem hiding this comment.
I thought I did that >.> Done for realz!
| } | ||
|
|
||
| @Test | ||
| public void logicalViewTest() { |
Contributor
There was a problem hiding this comment.
Same comments than for materialized views.
andre-sampaio
approved these changes
Apr 23, 2025
Contributor
andre-sampaio
left a comment
There was a problem hiding this comment.
lgtm! can you double check we are not leaving any dangling resources before merging?
4d3a7e6
into
googleapis:main
19 of 22 checks passed
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
🤖 I have created a release *beep* *boop* --- ## [2.58.0](https://togithub.com/googleapis/java-bigtable/compare/v2.57.3...v2.58.0) (2025-04-28) ### Features * Add deletion_protection support for LVs ([43c97a3](https://togithub.com/googleapis/java-bigtable/commit/43c97a3f430ee4ee90d46b3685ae50f13949831c)) * **bigtable:** Add integration tests for Materialized/Logical Views ([#2518](https://togithub.com/googleapis/java-bigtable/issues/2518)) ([4d3a7e6](https://togithub.com/googleapis/java-bigtable/commit/4d3a7e675b60ba6a3225a45b7463edff279f9bc4)) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.56.2 ([43c97a3](https://togithub.com/googleapis/java-bigtable/commit/43c97a3f430ee4ee90d46b3685ae50f13949831c)) * Fix retry info algorithm setting ([#2562](https://togithub.com/googleapis/java-bigtable/issues/2562)) ([c424ccb](https://togithub.com/googleapis/java-bigtable/commit/c424ccba72a191609dc726ed67d03f0d330015fc)) * Use universe domain when creating the monitoring client ([#2570](https://togithub.com/googleapis/java-bigtable/issues/2570)) ([3b51e12](https://togithub.com/googleapis/java-bigtable/commit/3b51e1206a4f83078625705ed8d8a899839af1a9)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.