Skip to content

chore: release main#6533

Merged
lqiu96 merged 2 commits into
mainfrom
release-please--branches--main
Apr 30, 2024
Merged

chore: release main#6533
lqiu96 merged 2 commits into
mainfrom
release-please--branches--main

Conversation

@release-please
Copy link
Copy Markdown
Contributor

@release-please release-please Bot commented Apr 25, 2024 •
edited
Loading

🤖 I have created a release beep boop

26.38.0

26.38.0 (2024-04-30)

Dependencies

  • update actions/checkout action to v4 (#6507) (5a9e817)
  • update actions/github-script action to v7 (#6508) (e2f9c9f)
  • update actions/setup-java action to v4 (#6509) (8aae14e)
  • update actions/setup-node action to v4 (#6510) (a20788d)
  • update dependency com.google.cloud:first-party-dependencies to v3.29.0 (#6540) (938cd30)
  • update dependency com.google.cloud:gapic-libraries-bom to v1.36.0 (#6549) (64ec4b5)
  • update dependency com.google.cloud:google-cloud-bigquery to v2.39.0 (#6541) (a5798fc)
  • update dependency com.google.cloud:google-cloud-bigquery to v2.39.1 (#6554) (075716c)
  • update dependency com.google.cloud:google-cloud-bigquerystorage-bom to v3.5.0 (#6551) (d4a55af)
  • update dependency com.google.cloud:google-cloud-bigtable-bom to v2.39.0 (#6543) (107b178)
  • update dependency com.google.cloud:google-cloud-datastore-bom to v2.19.1 (#6536) (4bd9f22)
  • update dependency com.google.cloud:google-cloud-firestore-bom to v3.20.2 (#6537) (5d4e4bf)
  • update dependency com.google.cloud:google-cloud-firestore-bom to v3.21.0 (#6550) (a497e07)
  • update dependency com.google.cloud:google-cloud-logging-bom to v3.17.0 (#6544) (9b4fd06)
  • update dependency com.google.cloud:google-cloud-logging-logback to v0.131.5-alpha (#6542) (8f5603b)
  • update dependency com.google.cloud:google-cloud-nio to v0.127.16 (#6538) (cd70cb1)
  • update dependency com.google.cloud:google-cloud-pubsub-bom to v1.129.0 (#6524) (c3fcf29)
  • update dependency com.google.cloud:google-cloud-pubsub-bom to v1.129.1 (#6539) (952991e)
  • update dependency com.google.cloud:google-cloud-pubsublite-bom to v1.13.3 (#6548) (20d3ebd)
  • update dependency com.google.cloud:google-cloud-spanner-bom to v6.65.0 (#6517) (c18e4a1)
  • update dependency com.google.cloud:google-cloud-spanner-bom to v6.65.1 (#6555) (f48df36)
  • update dependency com.google.cloud:google-cloud-spanner-jdbc to v2.17.0 (#6545) (4daf874)
  • update dependency com.google.cloud:google-cloud-storage-bom to v2.37.0 (#6546) (fa3d6b7)
  • update dependency com.google.googlejavaformat:google-java-format to v1.22.0 (#6518) (dcdaf2a)
  • update dependency commons-cli:commons-cli to v1.7.0 (#6547) (7e20379)
  • update dependency commons-io:commons-io to v2.16.1 (#6513) (a9d7444)

This PR was generated with Release Please. See documentation.

@release-please release-please Bot requested a review from a team April 25, 2024 18:43
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Apr 25, 2024
@release-please release-please Bot force-pushed the release-please--branches--main branch 6 times, most recently from d93d431 to b8e63c2 Compare April 25, 2024 18:46
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Apr 25, 2024
@release-please release-please Bot force-pushed the release-please--branches--main branch from b8780a6 to 02fdc39 Compare April 26, 2024 01:51
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Apr 26, 2024
@release-please release-please Bot force-pushed the release-please--branches--main branch 3 times, most recently from 4ba6461 to a01ff3c Compare April 26, 2024 01:55
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Apr 26, 2024
@release-please release-please Bot force-pushed the release-please--branches--main branch from a31eb21 to 65aeb12 Compare April 26, 2024 13:48
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Apr 26, 2024
@release-please release-please Bot force-pushed the release-please--branches--main branch 2 times, most recently from b93e5bf to af44916 Compare April 26, 2024 13:49
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Apr 26, 2024
@release-please release-please Bot force-pushed the release-please--branches--main branch 4 times, most recently from 5efd126 to e47287e Compare April 26, 2024 17:29
@release-please release-please Bot force-pushed the release-please--branches--main branch from 4ff96c0 to d1c2240 Compare April 26, 2024 17:45
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Apr 26, 2024

The "ci / shared-dependencies-convergence (pull_request)" detects the problem now. Nice.

Greatest shared-dependencies version: 3.29.0Greatest shared-dependencies version: 3.29.0
-----------------------
Found 4 artifacts with shared dependencies version: 3.28.1
- google-cloud-bigquerystorage:3.4.0
- google-cloud-bigquery:2.39.0
- google-cloud-bigtable-stats:2.37.0
- ```

@release-please release-please Bot force-pushed the release-please--branches--main branch 3 times, most recently from d1d7ab0 to ca8e71c Compare April 29, 2024 19:28
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Apr 29, 2024

@mpeddada1 The check has been failing. Can you take a look?

https://github.com/googleapis/java-cloud-bom/actions/runs/8884323589/job/24393152826?pr=6533

Apr 29, 2024 7:32:12 PM com.google.cloud.tools.opensource.cloudbomdashboard.ArtifactMavenData getSharedDependenciesVersionFromUrl
SEVERE: Failed to parse contents of POM file: https://repo1.maven.org/maven2/com/google/cloud/google-cloud-bigtable-stats-deps-bom/2.39.0/google-cloud-bigtable-stats-deps-bom-2.39.0.pom
java.io.FileNotFoundException: https://repo1.maven.org/maven2/com/google/cloud/google-cloud-bigtable-stats-deps-bom/2.39.0/google-cloud-bigtable-stats-deps-bom-2.39.0.pom
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1898)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1500)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:268)
	at java.net.URL.openStream(URL.java:1093)
	at com.google.cloud.tools.opensource.cloudbomdashboard.ArtifactMavenData.getSharedDependenciesVersionFromUrl(ArtifactMavenData.java:234)
	at com.google.cloud.tools.opensource.cloudbomdashboard.ArtifactMavenData.sharedDependencyPositionAndVersion(ArtifactMavenData.java:222)
	at com.google.cloud.tools.opensource.cloudbomdashboard.ArtifactMavenData.generateArtifactMavenData(ArtifactMavenData.java:122)
	at com.google.cloud.tools.opensource.cloudbomdashboard.VersionData.addData(VersionData.java:49)
	at com.google.cloud.tools.opensource.cloudbomdashboard.DashboardMain.report(DashboardMain.java:200)
	at com.google.cloud.tools.opensource.cloudbomdashboard.DashboardMain.main(DashboardMain.java:113)
	at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:254)
	at java.lang.Thread.run(Thread.java:750)

Apr 29, 2024 7:32:18 PM com.google.cloud.tools.opensource.cloudbomdashboard.ArtifactMavenData getSharedDependenciesVersionFromUrl
SEVERE: Failed to parse contents of POM file: https://repo1.maven.org/maven2/com/google/cloud/google-cloud-storage-control-parent/2.37.0-alpha/google-cloud-storage-control-parent-2.37.0-alpha.pom
java.io.FileNotFoundException: https://repo1.maven.org/maven2/com/google/cloud/google-cloud-storage-control-parent/2.37.0-alpha/google-cloud-storage-control-parent-2.37.0-alpha.pom
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1898)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1500)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:268)
	at java.net.URL.openStream(URL.java:1093)
	at com.google.cloud.tools.opensource.cloudbomdashboard.ArtifactMavenData.getSharedDependenciesVersionFromUrl(ArtifactMavenData.java:234)
	at com.google.cloud.tools.opensource.cloudbomdashboard.ArtifactMavenData.sharedDependencyPositionAndVersion(ArtifactMavenData.java:210)
	at com.google.cloud.tools.opensource.cloudbomdashboard.ArtifactMavenData.generateArtifactMavenData(ArtifactMavenData.java:122)
	at com.google.cloud.tools.opensource.cloudbomdashboard.VersionData.addData(VersionData.java:49)
	at com.google.cloud.tools.opensource.cloudbomdashboard.DashboardMain.report(DashboardMain.java:200)
	at com.google.cloud.tools.opensource.cloudbomdashboard.DashboardMain.main(DashboardMain.java:113)
	at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:254)
	at java.lang.Thread.run(Thread.java:750)

Greatest shared-dependencies version: 3.29.0Greatest shared-dependencies version: 3.29.0
-----------------------
Found 1 artifacts with shared dependencies version: 3.28.1
Warning: cloud-bigquery:2.39.0[WARNING] 
java.lang.RuntimeException: Failed to converge dependencies
    at com.google.cloud.tools.opensource.cloudbomdashboard.DashboardMain.main (DashboardMain.java:114)
    at org.codehaus.mojo.exec.ExecJavaMojo$1.run (ExecJavaMojo.java:254)
    at java.lang.Thread.run (Thread.java:750)

@mpeddada1
Copy link
Copy Markdown
Contributor

mpeddada1 commented Apr 29, 2024 •
edited
Loading

Thanks for the stacktrace! Looks like this PR only contains an update of google-cloud-bigquery to 2.39.0 which is on shared-dependencies:3.28.1. google-cloud-bigquery:2.39.1 contains an update to shared-dependencies:3.29.0:

Screenshot 2024-04-29 at 6 31 36 PM

[Update] Initial investigation of FileNotFoundException:

We recently added logging for exceptions the code was previously silencing them. But I think it is surfacing two issues: 1) It seems to be creating an incorrect pomURL for google-cloud-storage-controland google-cloud-bigtable-stats (e.g. https://repo1.maven.org/maven2/com/google/cloud/google-cloud-storage-control/2.37.0-alpha/ is available on Maven central) 2) It is looking for google-cloud-bigtable-stats-deps-bom:2.39.0 when the latest version I could find on maven central is https://repo1.maven.org/maven2/com/google/cloud/google-cloud-bigtable-stats/2.37.0/. The module was removed from the bom in this PR.

For #1, it looks like this is where the pom is generated:

java-cloud-bom/dashboard/src/main/java/com/google/cloud/tools/opensource/cloudbomdashboard/ArtifactMavenData.java

Lines 269 to 283 in 107b178

private static String generatePomFileUrl(Artifact artifact) {
String groupPath = artifact.getGroupId().replace('.', '/');
return DashboardMain.basePath
+ "/"
+ groupPath
+ "/"
+ artifact.getArtifactId()
+ "/"
+ artifact.getVersion()
+ "/"
+ artifact.getArtifactId()
+ "-"
+ artifact.getVersion()
+ ".pom";
}

@release-please release-please Bot force-pushed the release-please--branches--main branch 2 times, most recently from 5c06f0b to e02239c Compare April 30, 2024 15:03
@release-please release-please Bot force-pushed the release-please--branches--main branch from e02239c to 1fcb8de Compare April 30, 2024 15:04
@lqiu96
Copy link
Copy Markdown
Member

lqiu96 commented Apr 30, 2024

Error:

Warning:  The POM for com.google.cloud:google-cloud-bigtable-stats:jar:2.39.0 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  17.076 s
[INFO] Finished at: 2024-04-30T15:05:04Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal on project bom-validation-canary-project: Could not resolve dependencies for project com.google.cloud:bom-validation-canary-project:jar:0.0.1-SNAPSHOT: Could not find artifact com.google.cloud:google-cloud-bigtable-stats:jar:2.39.0 in central (https://repo.maven.apache.org/maven2) -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Error: Process completed with exit code 1.

Bigtable-stats jar is no longer being published. BigTable has removed it from their bom and should no longer be an issue going forward.

@lqiu96 lqiu96 merged commit 50044a1 into main Apr 30, 2024
@lqiu96 lqiu96 deleted the release-please--branches--main branch April 30, 2024 15:11
@release-please
Copy link
Copy Markdown
Contributor Author

release-please Bot commented Apr 30, 2024

🤖 Release is at https://github.com/googleapis/java-cloud-bom/releases/tag/v26.38.0 🌻

@release-trigger
Copy link
Copy Markdown

release-trigger Bot commented Apr 30, 2024

Triggered job: cloud-devrel/client-libraries/java/java-cloud-bom/release/stage (2024-04-30T15:12:08.596Z)

To trigger again, remove the autorelease: triggered label (in a few minutes).

@release-tool-publish-reporter
Copy link
Copy Markdown

release-tool-publish-reporter Bot commented Apr 30, 2024

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter
Copy link
Copy Markdown

release-tool-publish-reporter Bot commented Apr 30, 2024

🥚 You hatched a release! The release build finished successfully! 💜

@mpeddada1 mpeddada1 mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees

No one assigned

Labels

autorelease: published size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suztomo @mpeddada1 @lqiu96