Skip to content

Tests for 1.1.0#48

Merged
Warchant merged 3 commits into
hyperledger-iroha:masterfrom
Alexey-N-Chernyshov:1.1.0
Jul 29, 2019
Merged

Tests for 1.1.0#48
Warchant merged 3 commits into
hyperledger-iroha:masterfrom
Alexey-N-Chernyshov:1.1.0

Conversation

@Alexey-N-Chernyshov

@Alexey-N-Chernyshov Alexey-N-Chernyshov commented Jul 29, 2019

Copy link
Copy Markdown
Contributor

Added tests for commands and getAccDetails.
GetAccountDetails return type changed.

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>
Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>
@Alexey-N-Chernyshov Alexey-N-Chernyshov changed the title 1.1.0 Tests for 1.1.0 Jul 29, 2019

@Warchant Warchant left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix ci and it can be merged

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>
@Warchant Warchant merged commit 3cac393 into hyperledger-iroha:master Jul 29, 2019
@codecov-io

codecov-io commented Jul 29, 2019

Copy link
Copy Markdown

Codecov Report

Merging #48 into master will increase coverage by 0.85%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #48      +/-   ##
============================================
+ Coverage      72.4%   73.26%   +0.85%     
- Complexity      346      349       +3     
============================================
  Files            38       38              
  Lines          1602     1601       -1     
  Branches         50       50              
============================================
+ Hits           1160     1173      +13     
+ Misses          360      347      -13     
+ Partials         82       81       -1
Impacted Files Coverage Δ Complexity Δ
...main/java/jp/co/soramitsu/iroha/java/QueryAPI.java 73.21% <100%> (-2.9%) 19 <0> (ø)
.../java/jp/co/soramitsu/iroha/java/QueryBuilder.java 54.28% <0%> (+0.47%) 24% <0%> (+1%) ⬆️
...jp/co/soramitsu/iroha/java/TransactionBuilder.java 81.78% <0%> (+5.49%) 40% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca50127...ae674d8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants