Fixed Iroha container port#49
Merged
Warchant merged 2 commits intoAug 13, 2019
Merged
Conversation
Signed-off-by: Anton Dolgopolov <dolgopolov@soramitsu.co.jp>
Alexey-N-Chernyshov
approved these changes
Aug 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
============================================
- Coverage 73.01% 72.74% -0.28%
Complexity 346 346
============================================
Files 38 38
Lines 1601 1607 +6
Branches 50 51 +1
============================================
Hits 1169 1169
- Misses 350 355 +5
- Partials 82 83 +1
Continue to review full report at Codecov.
|
Signed-off-by: Anton Dolgopolov <dolgopolov@soramitsu.co.jp>
Warchant
approved these changes
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
withFixedPortmethod that allows setting a fixed Iroha port.