Map and Set#263
Merged
Merged
Conversation
EzequielCaste
requested changes
Jul 4, 2020
EzequielCaste
left a comment
Contributor
There was a problem hiding this comment.
Hay error al comienzo de 1-js/05-data-types/07-map-set/02-filter-anagrams/solution.md
No se ha respetado los números de las líneas. Debe comenzar en línea N° 1 y no en la N°2.
Por favor corregir así puedo seguir con la revisión.
|
Please make the requested changes. After it, add a comment "/done". |
arreglé el problema de los espacios. Por favor tienen que coincidir los números de las líneas con el documento Original.
problemas con la numeración de líneas
número de líneas
respetar el número de línea
EzequielCaste
requested changes
Jul 4, 2020
EzequielCaste
left a comment
Contributor
There was a problem hiding this comment.
muchos problemas con espacios donde no deberían estar.
Se debe respetar el número de línea del documento original.
|
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Contributor
Author
|
/done |
EzequielCaste
approved these changes
Jul 5, 2020
|
Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉 |
Member
|
@vplentinax @ezzep66 |
Contributor
Author
|
En mis PR el segundo review lo doy yo jejeje. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arreglado los errores de formato.