Skip to content

Stop showing cached PRs when we no longer have a base remote#5543

Merged
stefanhaller merged 1 commit into
masterfrom
clear-pr-cache-when-no-base-remote
Apr 26, 2026
Merged

Stop showing cached PRs when we no longer have a base remote#5543
stefanhaller merged 1 commit into
masterfrom
clear-pr-cache-when-no-base-remote

Conversation

@stefanhaller

@stefanhaller stefanhaller commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

If we used to have a base remote (e.g. because there was only one), but now we don't (e.g. because the user has added a second one, and we don't know yet which one is the base), stop showing the cached PRs. This is especially important in the case that the user cancels the prompt, in which case we don't have a base remote for the rest of the session, but would keep showing the (potentially stale) cached PRs forever.

You might ask why we don't retain the previous base remote in the case that we used to have one but no longer do; this may be possible, but it's error-prone because the user might have shuffled their remotes around and changed their names. I don't think it's worth the risk.

If we used to have a base remote (e.g. because there was only one), but now we
don't (e.g. because the user has added a second one, and we don't know yet which
one is the base), stop showing the cached PRs. This is especially important in
the case that the user cancels the prompt, in which case we don't have a base
remote for the rest of the session, but would keep showing the (potentially
stale) cached PRs forever.
@stefanhaller stefanhaller added the bug Something isn't working label Apr 26, 2026
@stefanhaller stefanhaller enabled auto-merge April 26, 2026 14:51
@stefanhaller stefanhaller merged commit c826d83 into master Apr 26, 2026
14 checks passed
@stefanhaller stefanhaller deleted the clear-pr-cache-when-no-base-remote branch April 26, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant