Stop showing cached PRs when we no longer have a base remote#5543
Merged
Conversation
If we used to have a base remote (e.g. because there was only one), but now we don't (e.g. because the user has added a second one, and we don't know yet which one is the base), stop showing the cached PRs. This is especially important in the case that the user cancels the prompt, in which case we don't have a base remote for the rest of the session, but would keep showing the (potentially stale) cached PRs forever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we used to have a base remote (e.g. because there was only one), but now we don't (e.g. because the user has added a second one, and we don't know yet which one is the base), stop showing the cached PRs. This is especially important in the case that the user cancels the prompt, in which case we don't have a base remote for the rest of the session, but would keep showing the (potentially stale) cached PRs forever.
You might ask why we don't retain the previous base remote in the case that we used to have one but no longer do; this may be possible, but it's error-prone because the user might have shuffled their remotes around and changed their names. I don't think it's worth the risk.