Update to tcell v3#5562
Merged
Merged
Conversation
Should have been deleted in b955002.
The wrappedHandler business is no longer needed (and maybe never was).
It's a no-op. (I think this might not have been the case in the past, where Label() was needed to "normalize" a keybinding or something.)
This is to free up the name Key for a type that can be either a KeyName or a rune (or later a string when we upgrade to tcell v3).
This bundles the keyName and a rune, so that we don't have to pass these around separately everywhere. This should make it easier to swap out the rune for a string when we upgrade to tcell v3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor code to introduce a Key type in gocui that bundles the keyName and a rune, so that we don't have to pass these around separately everywhere.
This, and updating tcell to v3 lays the ground for supporting more keybindings in terminals that support the CSIu keyboard protocol.