Change canonical keybinding syntax (<ctrl+a> instead of <c-a>)#5565
Merged
Conversation
With the new longer syntax that we are about to make the default in the next commit it is no longer needed.
…instead of - The change to filter_menu_by_keybinding.go is needed because + now occurs in many keybindings, so pick a different one that occurs only once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5563 we started to support an alternative syntax for keybindings: instead of
<c-a>you could say<ctrl+a>, which is easier to read especially when there are multiple modifiers (<ctrl+shift+x>instead of<c-s-x>). In this PR we make this new syntax the default.