pkg/runc: Revert to 1.0.0-rc90#3761
Closed
the-maldridge wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the extra information. I think the next step I’d like to take is
to add a CI test which demonstrates the bug and then we can more easily
test potential fixes, and prevent problems recurring in future.
…On Sat, 29 Jan 2022 at 19:20, Michael Aldridge ***@***.***> wrote:
This commit reverts runc to version 1.0.0-rc90 which is the last known
version to not have any degraded functionality with linuxkit. The
first known broken version is 1.0.0-rc91, and a bisect between these
two bounds shows the breakage first appearing at
60e21ec26e15945259d4b1e790e8fd119ee86467. As I don't have the time
nor knowledge to debug this further, my best suggestion I can offer is
to revert to the most recent version that worked.
Signed-off-by: Michael Aldridge ***@***.***
*- What I did*
*- How I did it*
*- How to verify it*
*- Description for the changelog*
*- A picture of a cute animal (not mandatory but encouraged)*
------------------------------
You can view, comment on, or merge this pull request online at:
#3761
Commit Summary
- 832988d
<832988d>
pkg/runc: Revert to 1.0.0-rc90
File Changes
(1 file <https://github.com/linuxkit/linuxkit/pull/3761/files>)
- *M* pkg/runc/Dockerfile
<https://github.com/linuxkit/linuxkit/pull/3761/files#diff-e8dc4a862affacb010e653190af3a4f69deeba514c17cbe0fb3203271a0169a8>
(2)
Patch Links:
- https://github.com/linuxkit/linuxkit/pull/3761.patch
- https://github.com/linuxkit/linuxkit/pull/3761.diff
—
Reply to this email directly, view it on GitHub
<#3761>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABQPOTWMZJXZMFVSMX47NDUYQ4WVANCNFSM5NDHPXCA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
Author
|
Sure, is there an existing framework within linuxkit for tests that boot VMs or is there some other paradigm you'd like to see for a test here? The way I did the bisect was by building a VM with a suspect version in it and looking to see if acpid is running or not since that failed at the same time as dockerd did. |
Contributor
|
The tests are shell scripts run by a python tool called “rtf”. For example
here’s a cgroupv2 test:
https://github.com/linuxkit/linuxkit/blob/master/test/cases/040_packages/003_cgroupv2/test.sh
They’re run by the GitHub actions so hopefully the logs are visible. The
biggest gotcha at the moment is that changes to packages (eg runc) are not
automatically picked up because all the image hashes are pinned. In the
past I’ve pushed an image to somewhere I have write access to, then
reference that temporarily in the PR as a test. This is a limitation of the
CI setup that we’re hoping to improve.
…On Sun, 30 Jan 2022 at 00:45, Michael Aldridge ***@***.***> wrote:
Sure, is there an existing framework within linuxkit for tests that boot
VMs or is there some other paradigm you'd like to see for a test here? The
way I did the bisect was by building a VM with a suspect version in it and
looking to see if acpid is running or not since that failed at the same
time as dockerd did.
—
Reply to this email directly, view it on GitHub
<#3761 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABQPOXI6255UVC6VSRG6TLUYSC3HANCNFSM5NDHPXCA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
Author
|
While writing the test I came across that something in linuxkit is generally pretty broken right now. Please review and comment on #3756. |
This commit reverts runc to version 1.0.0-rc90 which is the last known version to not have any degraded functionality with linuxkit. The first known broken version is 1.0.0-rc91, and a bisect between these two bounds shows the breakage first appearing at 60e21ec26e15945259d4b1e790e8fd119ee86467. As I don't have the time nor knowledge to debug this further, my best suggestion I can offer is to revert to the most recent version that worked. Signed-off-by: Michael Aldridge <aldridge.mac@gmail.com>
832988d to
7fe24e6
Compare
Contributor
Author
|
Obsoleted by the information provided in #3735 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reverts runc to version 1.0.0-rc90 which is the last known
version to not have any degraded functionality with linuxkit. The
first known broken version is 1.0.0-rc91, and a bisect between these
two bounds shows the breakage first appearing at
60e21ec26e15945259d4b1e790e8fd119ee86467. As I don't have the time
nor knowledge to debug this further, my best suggestion I can offer is
to revert to the most recent version that worked.
Signed-off-by: Michael Aldridge aldridge.mac@gmail.com
- What I did
Reverted runc
- How I did it
by typing?
- How to verify it
build the package, observe that the version number is different.
- Description for the changelog