Correct test input code to support older go versions#490
Merged
Conversation
Samples used for testing need to have build tags for new and old style: //go:build tag // +build tag
natefinch
approved these changes
Nov 18, 2023
natefinch
left a comment
Member
There was a problem hiding this comment.
Thank you! Nothing should be imported outside the stdlib anyway. I don't want this tool to require outside imports when you build it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samples used for testing need to have build tags for new and old style:
The particular problem here, seems to be that 1.16 was actually importing the package referred in the
TestGoModulestest (import "golang.org/x/text/unicode/norm") which, in the CI system's version lacks an old style go tag comment. Hence go complaining of a//go:buildwithout a// +build. I made all files bi-tagged for consistency.