Implement overloaded condition method selection based on parameter count#4055
Open
daberni wants to merge 2 commits into
Open
Implement overloaded condition method selection based on parameter count#4055daberni wants to merge 2 commits into
daberni wants to merge 2 commits into
Conversation
- Add selectMostSpecificConditionMethod to choose condition method with most bindable parameters - Update getPresenceCheck and getPresenceCheckForSourceParameter to use new selection logic - Add regression test OverloadedConditionTest to validate the fix for issue mapstruct#3993
0e3cb18 to
03df4c6
Compare
0c7ac12 to
1c1e6dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the fix for issue #3993 by adding logic to select the most specific overloaded condition method based on the number of bindable parameters.
Changes:
The implementation allows overloaded condition methods by choosing the one with the most parameters that can be bound, avoiding ambiguity errors.