Skip to content

modernize packaging tests boilerplate (don't run setup.py directly, don't create zip package, remove unnecessary dependencies)#24

Merged
mbdevpl merged 9 commits into
mainfrom
feature/dont-run-setuppy-directly-in-tests
Apr 22, 2025
Merged

modernize packaging tests boilerplate (don't run setup.py directly, don't create zip package, remove unnecessary dependencies)#24
mbdevpl merged 9 commits into
mainfrom
feature/dont-run-setuppy-directly-in-tests

Conversation

@mbdevpl

@mbdevpl mbdevpl commented Apr 22, 2025

Copy link
Copy Markdown
Owner
  • don't run setup.py directly in tests
  • don't build and test for zip source dist anymore
  • don't depend on packages which are not actually needed

@mbdevpl mbdevpl self-assigned this Apr 22, 2025
@jenkins-mbdev

jenkins-mbdev Bot commented Apr 22, 2025

Copy link
Copy Markdown

First PR build failed: GitHub-mbdevpl/python-boilerplates/PR-24 [build #1]

@mbdevpl mbdevpl force-pushed the feature/dont-run-setuppy-directly-in-tests branch from 2e0f9f0 to 98b29c3 Compare April 22, 2025 13:06
@jenkins-mbdev

jenkins-mbdev Bot commented Apr 22, 2025

Copy link
Copy Markdown

Tools report for GitHub-mbdevpl/python-boilerplates/PR-24 [build #5]:

  • Pylint: ran 🆗

  • Mypy: ran 🆗

  • Flake518: ran 🆗

  • Pydocstyle: ran 🆗

  • Coverage: 99% 🆗 (click for details)
    Name                              Stmts   Miss Branch BrPart  Cover   Missing
    -----------------------------------------------------------------------------
    boilerplates/__init__.py              2      0      0      0   100%
    boilerplates/cli.py                  52      0     10      0   100%
    boilerplates/config.py               17      0      4      0   100%
    boilerplates/git_repo_tests.py       59      0     10      0   100%
    boilerplates/logging.py             124      0     20      0   100%
    boilerplates/packaging_tests.py     110      0      8      0   100%
    boilerplates/sentry.py               65      0      6      0   100%
    boilerplates/setup.py               204      0     64      0   100%
    setup.py                             34      9      6      1    70%   18-26
    test/__init__.py                      6      0      0      0   100%
    test/test_cli.py                     68      0     12      0   100%
    test/test_config.py                  31      0      0      0   100%
    test/test_git_repo.py                21      0      0      0   100%
    test/test_logging.py                 89      0      6      0   100%
    test/test_packaging.py                5      0      0      0   100%
    test/test_sentry.py                  46      0      0      0   100%
    test/test_setup.py                  156      0     16      0   100%
    -----------------------------------------------------------------------------
    TOTAL                              1089      9    162      1    99%
    

@jenkins-mbdev

jenkins-mbdev Bot commented Apr 22, 2025

Copy link
Copy Markdown

@codecov

codecov Bot commented Apr 22, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (abb81e8) to head (650efab).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          17       17           
  Lines        1083     1089    +6     
  Branches       81       81           
=======================================
+ Hits         1083     1089    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbdevpl mbdevpl merged commit 0b39681 into main Apr 22, 2025
@mbdevpl mbdevpl deleted the feature/dont-run-setuppy-directly-in-tests branch April 22, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant