fix(mcp): support moz-firefox BiDi channels via --browser#41126
Open
jrmuizel wants to merge 1 commit into
Open
fix(mcp): support moz-firefox BiDi channels via --browser#41126jrmuizel wants to merge 1 commit into
jrmuizel wants to merge 1 commit into
Conversation
yury-s
approved these changes
Jun 3, 2026
yury-s
reviewed
Jun 3, 2026
Contributor
Test results for "MCP"7230 passed, 1103 skipped Merge workflow run. |
playwright-core already registers the `moz-firefox`, `moz-firefox-beta`
and `moz-firefox-nightly` channels and routes them through WebDriver BiDi
(Firefox.launch branches on `channel.startsWith('moz-')`), but the MCP
layer never plumbed them through:
- resolveBrowserParam() did not recognize the moz-firefox* values, so
`--browser moz-firefox` resolved to no channel.
- mergeConfig() dropped the channel for any non-chromium browser, which
also discarded a valid Firefox BiDi channel coming from a config file.
Recognize the moz-firefox* channels in resolveBrowserParam(), and keep
moz-* channels in mergeConfig() instead of stripping them.
d1b86db to
776bda4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
playwright-core already registers the
moz-firefox,moz-firefox-betaandmoz-firefox-nightlychannels and routes them through WebDriver BiDi (Firefox.launch branches onchannel.startsWith('moz-')), but the MCP layer never plumbed them through:--browser moz-firefoxresolved to no channel.Recognize the moz-firefox* channels in resolveBrowserParam(), and keep moz-* channels in mergeConfig() instead of stripping them.