Skip to content

Fix Chinese punctuation regex comment#1012

Merged
you-n-g merged 2 commits into
microsoft:mainfrom
Chaoyingz:fix-comment
Mar 29, 2022
Merged

Fix Chinese punctuation regex comment#1012
you-n-g merged 2 commits into
microsoft:mainfrom
Chaoyingz:fix-comment

Conversation

@Chaoyingz
Copy link
Copy Markdown
Contributor

Description

Fix Chinese punctuation regex comment.

Motivation and Context

The previous comment was wrong and not clear enough.

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g
Copy link
Copy Markdown
Contributor

you-n-g commented Mar 29, 2022

Thanks!
It looks great!

@you-n-g you-n-g merged commit 3c4f4bf into microsoft:main Mar 29, 2022
@Chaoyingz Chaoyingz deleted the fix-comment branch March 29, 2022 01:58
@you-n-g you-n-g added the enhancement New feature or request label Apr 24, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
you-n-g pushed a commit to you-n-g/qlib that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants