Fix Click 8.3 serve livereload default#4143
Open
marko1olo wants to merge 1 commit into
Open
Conversation
Author
|
CI note: the current test failures I inspected are the existing Representative failed jobs:
The PR-specific checks are green for lint/style/build/package, and the local Click-focused CLI regression passes on both Click 8.3.0 and Click 8.4.1 as listed in the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4032.
Refs #4014.
Summary
--livereload/--no-livereloadflag_valueoptions with Click's paired boolean option formmkdocs servedefaulting tolivereload=Trueon Click 8.3.0, so watch paths are registered againbuild_type,strict,use_directory_urls), not just livereloadVerification
CLITests.test_serve_defaultpassedlivereload=Falseintomkdocs.commands.serve.serveC:\hades\oss\.venvs\mkdocs-4032-click830\Scripts\python.exe -m unittest mkdocs.tests.cli_testswith Click 8.3.0: 37 passedC:\hades\oss\.venvs\mkdocs-4045\Scripts\python.exe -m unittest mkdocs.tests.cli_testswith Click 8.4.1: 37 passedC:\hades\oss\.venvs\mkdocs-4045\Scripts\python.exe -m black --check --diff --target-version py313 mkdocs\__main__.py: passedC:\hades\oss\.venvs\mkdocs-4045\Scripts\isort.exe --check-only --diff mkdocs\__main__.py: passedgit diff --check: passedNote:
ruff check mkdocs\__main__.pyreports pre-existing lazy-import/style findings in this file that are outside this patch;ruff check --diff mkdocs\__main__.pyreports no fixable diff.