Fix GPG KEY#1678
Merged
Merged
Conversation
tastelikefeet
approved these changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GPG_KEY environment variable in the Dockerfiles to include an additional key and modifies the gpg --recv-keys command to support multiple keys. A redundant block of ARG and ENV definitions was identified in docker/Dockerfile.extra_install that should be removed to improve maintainability.
Comment on lines
38
to
42
| #install and config python copy from https://github.com/docker-library/python/blob/1b7a1106674a21e699b155cbd53bf39387284cca/3.10/bookworm/Dockerfile | ||
| ARG PYTHON_VERSION={python_version} | ||
| ENV PATH /usr/local/bin:$PATH | ||
| ENV GPG_KEY A035C8C19219BA821ECEA86B64E628F8D684696D | ||
| ENV GPG_KEY="A035C8C19219BA821ECEA86B64E628F8D684696D 7169605F62C751356D054A26A821E680E5FA6305" | ||
| ENV PYTHON_VERSION {python_version} |
Contributor
There was a problem hiding this comment.
This block is a duplicate of lines 32-36. Redundant definitions of ARG and ENV variables should be removed to improve maintainability and reduce clutter in the Dockerfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.