[Fix] Fix dataset preview args, private streaming auth, and download retries#1700
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the dataset download utility with detailed logging, request timing, and a mechanism to filter configuration arguments based on the builder's dataclass fields. Key feedback includes a recommendation to include ReadTimeout in the retry logic to handle transient network issues, a suggestion to use time.perf_counter() for more precise duration measurements, and a warning that the current filtering of config_kwargs may strip necessary arguments intended for the DatasetBuilder constructor.
Jintao-Huang
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes
engine) before passing toBuilderConfig.__init__()to preventTypeError.HfFileSystemto inject them_session_idcookie, resolving 404 errors when loading private datasets withstreaming=True.ReadTimeout: IncludeReadTimeoutin the retry logic alongside connection errors to handle transient download failures.✨ Improvements
HfFileSystempatches remain active during streaming mode and are only restored in non-streaming contexts.