Fix 3 latent bugs: unusable Google-Fonts URLs, 2-char search terms, wrong --persist path#321
Open
OmexIT wants to merge 1 commit into
Open
Conversation
…rsist path) All three are in the canonical src/ tree, reproduced on Python 3.14.5: 1. data/typography.csv — all 73 'Google Fonts URL' values were unusable fonts.google.com/share *UI* links, not stylesheet hrefs. Replaced with the proper fonts.googleapis.com/css2 URLs (extracted verbatim from each row's correct 'CSS Import' column), so the URL column is actually loadable. 2. scripts/core.py — BM25 tokenizer kept only words >2 chars, so common design terms 'ux', 'ui', 'ai', '3d' tokenized to nothing and returned 0 results (e.g. `--domain style "3d"`). Changed >2 to >=2; '3d'/'ai' now match. 3. scripts/search.py — `--persist` without `-p` printed 'design-system/default/' but actually wrote to the query slug (e.g. design-system/fintech-crypto/). Use the same default the writer uses so the printed path matches reality. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three latent bugs in the canonical
src/ui-ux-pro-max/tree, each reproduced on Python 3.14.5.1.
data/typography.csv— Google Fonts URLs are unusableAll 73
Google Fonts URLvalues arehttps://fonts.google.com/share?...links — these are the Google Fonts UI "share" links, not loadable stylesheet hrefs. Anything that consumes that column gets a non-functional URL. Fixed by replacing each with the properhttps://fonts.googleapis.com/css2?...URL, extracted verbatim from the same row's already-correctCSS Importcolumn (no data invented).2.
scripts/core.py— 2-char design terms are unsearchableThe BM25 tokenizer keeps only words longer than 2 chars (
len(w) > 2), soux,ui,ai,3dtokenize to nothing and always return 0 results — e.g.search.py "3d" --domain styleandsearch.py "ai" --domain stylereturned nothing despite3D & Hyperrealismetc. existing. Changed to>= 2; both now return matches.3.
scripts/search.py—--persistprints the wrong path--design-system --persistwithout-pprintsdesign-system/default/but actually writes to the query slug (e.g.design-system/fintech-crypto/). The confirmation message now uses the same default the writer uses, so the printed path matches what's created.Verification
All three reproduced before / confirmed fixed after, on Python 3.14.5.
--design-systemoutput otherwise unchanged.Two more observations (left out to keep this diff focused)
templates/base/skill-content.mdexamples (and the generatedSKILL.md) usepython3 skills/ui-ux-pro-max/scripts/search.py, a relative path that fails from the installed location (~/.claude/skills/ui-ux-pro-max/).skill.json(andcli/assets/templates/platforms/*.json) say "across 10 stacks" but the skill now ships 16 stack CSVs (adds angular, astro, laravel, threejs, nuxtjs, nuxt-ui, jetpack-compose).Happy to follow up on either if useful.
🤖 Generated with Claude Code