This repository was archived by the owner on Dec 19, 2025. It is now read-only.
bitcoin: fix value floating point precision issue#336
Open
matthewjablack wants to merge 1 commit into
Open
Conversation
- Value previously used `Math.trunc` for `fromBitcoin` which can result in off by one sat issues - Switching to using Math.round solves this issue - Added test which fails using `Math.trunc`
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
=======================================
Coverage 93.17% 93.17%
=======================================
Files 226 226
Lines 6271 6271
Branches 730 730
=======================================
Hits 5843 5843
Misses 286 286
Partials 142 142 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches
Value.fromBitcointo useMath.roundinstead ofMath.truncsince it can result in off by one sat issuesFor example,
Value.fromBitcoin(20000000.00000008).bitcoinequals20000000.00000007not20000000.00000008if usingMath.trunc