Skip to content

assert: Add support for Map and Set in deepEqual #12142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josephg wants to merge 13 commits into from
Closed

assert: Add support for Map and Set in deepEqual #12142

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
561561a
assert: Add support for Map and Set in deepEqual
josephg Mar 31, 2017
f051840
assert: Use isSet and isMap from process.binding
josephg Mar 31, 2017
1d6cda6
assert: Added deeper equality checking for Map,Set
josephg Mar 31, 2017
800ae46
assert: Fixed nit in code review
josephg Mar 31, 2017
031f6f3
assert: Fixed typo in comment
josephg Mar 31, 2017
d6baaee
assert: var -> const and added tests
josephg Mar 31, 2017
8fb6ebf
assert: restrict O(n^2) search
josephg Mar 31, 2017
acef701
assert: added null check in set/map short circuit
josephg Apr 1, 2017
ee131e8
assert: update documentation to reflect changes
josephg Apr 1, 2017
7bc29b0
assert: Updated based on PR
josephg Apr 1, 2017
6bdfcaf
assert: updated docs based on PR
josephg Apr 1, 2017
fc5196a
assert: fixed docs # link
josephg Apr 1, 2017
7f9d4d8
assert: refactored based on PR
josephg Apr 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
assert: Use isSet and isMap from process.binding 
Updated PR based on comments

Ref: #12142
  • Loading branch information
@josephg
josephg committed Mar 31, 2017
commit f0518408bf63390732382a3a4a0de3dee79c8308
9 changes: 1 addition & 8 deletions lib/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
// UTILITY
const compare = process.binding('buffer').compare;
const util = require('util');
const { isSet, isMap } = process.binding('util');
const objectToString = require('internal/util').objectToString;
const Buffer = require('buffer').Buffer;

Expand Down Expand Up @@ -161,14 +162,6 @@ function isArguments(tag) {
return tag === '[object Arguments]';
}

function isMap(object) {
return object.constructor === Map;
}

function isSet(object) {
return object.constructor === Set;
}

function _deepEqual(actual, expected, strict, memos) {
// All identical values are equivalent, as determined by ===.
if (actual === expected) {
Expand Down