Skip to content

test: remove require('buffer') on 6 test files #13845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sallen450 wants to merge 1 commit into from
Closed

test: remove require('buffer') on 6 test files #13845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove require('buffer') on 6 test files 
* test/parallel/test-fs-mkdtemp.js
* test/parallel/test-fs-read-zero-length.js
* test/parallel/test-fs-read.js
* test/parallel/test-fs-whatwg-url.js
* test/parallel/test-fs-write-string-coerce.js
* test/parallel/test-fs-write.js

Refs: #13836
  • Loading branch information
@sallen450
sallen450 committed Jun 21, 2017
commit e8c82f05ec3ead9d3c18dd02fc2e0e96be0db1ca
1 change: 0 additions & 1 deletion test/parallel/test-fs-mkdtemp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ const common = require('../common');
const assert = require('assert');
const fs = require('fs');
const path = require('path');
const Buffer = require('buffer').Buffer;

common.refreshTmpDir();

Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-fs-read-zero-length.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
const common = require('../common');
const assert = require('assert');
const path = require('path');
const Buffer = require('buffer').Buffer;
const fs = require('fs');
const filepath = path.join(common.fixturesDir, 'x.txt');
const fd = fs.openSync(filepath, 'r');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-fs-read.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
const common = require('../common');
const assert = require('assert');
const path = require('path');
const Buffer = require('buffer').Buffer;
const fs = require('fs');
const filepath = path.join(common.fixturesDir, 'x.txt');
const fd = fs.openSync(filepath, 'r');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-fs-whatwg-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const path = require('path');
const fs = require('fs');
const os = require('os');
const URL = require('url').URL;
const Buffer = require('buffer').Buffer;

function pathToFileURL(p) {
if (!path.isAbsolute(p))
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-fs-write-string-coerce.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
const common = require('../common');
const assert = require('assert');
const path = require('path');
const Buffer = require('buffer').Buffer;
const fs = require('fs');

common.refreshTmpDir();
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-fs-write.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
const common = require('../common');
const assert = require('assert');
const path = require('path');
const Buffer = require('buffer').Buffer;
const fs = require('fs');
const fn = path.join(common.tmpDir, 'write.txt');
const fn2 = path.join(common.tmpDir, 'write2.txt');
Expand Down