Skip to content

[v6.x backport] tools: apply stricter indentation rules to tools #14360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

[v6.x backport] tools: apply stricter indentation rules to tools #14360

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13308b2
tools: remove no-useless-regex-char-class-escape
Trott Jan 1, 2017
8ab455e
tools: fix indentation in required-modules.js
Trott Jun 18, 2017
1ebad50
tools: apply stricter indentation rules to tools
Trott Jun 18, 2017
1088e81
tools: fix error in custom ESLint rule
Trott Jun 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tools: fix error in custom ESLint rule 
Fix previously-unnoticed typo in `required-modules.js`.

Refs: #13758 (comment)
PR-URL: #13758
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
@Trott
Trott committed Jul 19, 2017
commit 1088e81fc6b50333d8bc27411307c607b8e473e5
2 changes: 1 addition & 1 deletion tools/eslint-rules/required-modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ module.exports = function(context) {
if (foundModules.length < requiredModules.length) {
var missingModules = requiredModules.filter(
function(module) {
return foundModules.indexOf(module === -1);
return foundModules.indexOf(module) === -1;
}
);
missingModules.forEach(function(moduleName) {
Expand Down