Skip to content

test_runner: catch errors thrown within describe #43729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Jul 12, 2022
Merged

test_runner: catch errors thrown within describe #43729

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d90d824
test_runner: catch errors thrown within `describe`
MoLow Jul 10, 2022
e893a68
Update lib/internal/test_runner/test.js
MoLow Jul 10, 2022
51bfe9a
fix test
MoLow Jul 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/test_runner/test.js 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@MoLow @aduh95
MoLow and aduh95 committed Jul 11, 2022
commit e893a6845b1b4055284d36800c1512241e91b3b5
4 changes: 1 addition & 3 deletions lib/internal/test_runner/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,9 +360,7 @@ class Test extends AsyncResource {
if (this.endTime < this.startTime) {
this.endTime = hrtime();
}
if (this.startTime === null) {
this.startTime = this.endTime;
}
this.startTime ??= this.endTime;

// The test has run, so recursively cancel any outstanding subtests and
// mark this test as failed if any subtests failed.
Expand Down