Skip to content

v2.x - do not mutate core-util-is module #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 3 commits into from
Jan 5, 2020
Merged

v2.x - do not mutate core-util-is module #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b183eeb
build replacements - do not mutate core-util-is module
kumavis Dec 27, 2019
727d674
ci - use default npm version for non-legacy
kumavis Dec 28, 2019
3ce2a4d
ci - drop unused TASK env var
kumavis Dec 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 9 additions & 30 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,54 +1,33 @@
sudo: false
language: node_js
before_install:
- npm install -g npm@2
- test $NPM_LEGACY && npm install -g npm@latest-3 || npm install npm -g
- (test $NPM_LEGACY && npm install -g npm@2 && npm install -g npm@3) || true
notifications:
email: false
matrix:
fast_finish: true
include:
- node_js: '0.8'
env:
- TASK=test
- NPM_LEGACY=true
env: NPM_LEGACY=true
- node_js: '0.10'
env:
- TASK=test
- NPM_LEGACY=true
env: NPM_LEGACY=true
- node_js: '0.11'
env:
- TASK=test
- NPM_LEGACY=true
env: NPM_LEGACY=true
- node_js: '0.12'
env:
- TASK=test
- NPM_LEGACY=true
env: NPM_LEGACY=true
- node_js: 1
env:
- TASK=test
- NPM_LEGACY=true
env: NPM_LEGACY=true
- node_js: 2
env:
- TASK=test
- NPM_LEGACY=true
env: NPM_LEGACY=true
- node_js: 3
env:
- TASK=test
- NPM_LEGACY=true
env: NPM_LEGACY=true
- node_js: 4
env: TASK=test
- node_js: 5
env: TASK=test
- node_js: 6
env: TASK=test
- node_js: 7
env: TASK=test
- node_js: 8
env: TASK=test
- node_js: 9
env: TASK=test
script: "npm run $TASK"
script: "npm run test"
env:
global:
- secure: rE2Vvo7vnjabYNULNyLFxOyt98BoJexDqsiOnfiD6kLYYsiQGfr/sbZkPMOFm9qfQG7pjqx+zZWZjGSswhTt+626C0t/njXqug7Yps4c3dFblzGfreQHp7wNX5TFsvrxd6dAowVasMp61sJcRnB2w8cUzoe3RAYUDHyiHktwqMc=
Expand Down
2 changes: 1 addition & 1 deletion build/files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const headRegexp = /(^module.exports = \w+;?)/m

, utilReplacement = [
/^const util = require\('util'\);/m
, '\n/*<replacement>*/\nconst util = require(\'core-util-is\');\n'
, '\n/*<replacement>*/\nconst util = Object.create(require(\'core-util-is\'));\n'
+ 'util.inherits = require(\'inherits\');\n/*</replacement>*/\n'
]

Expand Down
2 changes: 1 addition & 1 deletion lib/_stream_duplex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ var objectKeys = Object.keys || function (obj) {
module.exports = Duplex;

/*<replacement>*/
var util = require('core-util-is');
var util = Object.create(require('core-util-is'));
util.inherits = require('inherits');
/*</replacement>*/

Expand Down
2 changes: 1 addition & 1 deletion lib/_stream_passthrough.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ module.exports = PassThrough;
var Transform = require('./_stream_transform');

/*<replacement>*/
var util = require('core-util-is');
var util = Object.create(require('core-util-is'));
util.inherits = require('inherits');
/*</replacement>*/

Expand Down
2 changes: 1 addition & 1 deletion lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function _isUint8Array(obj) {
/*</replacement>*/

/*<replacement>*/
var util = require('core-util-is');
var util = Object.create(require('core-util-is'));
util.inherits = require('inherits');
/*</replacement>*/

Expand Down
2 changes: 1 addition & 1 deletion lib/_stream_transform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ module.exports = Transform;
var Duplex = require('./_stream_duplex');

/*<replacement>*/
var util = require('core-util-is');
var util = Object.create(require('core-util-is'));
util.inherits = require('inherits');
/*</replacement>*/

Expand Down
2 changes: 1 addition & 1 deletion lib/_stream_writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ var Duplex;
Writable.WritableState = WritableState;

/*<replacement>*/
var util = require('core-util-is');
var util = Object.create(require('core-util-is'));
util.inherits = require('inherits');
/*</replacement>*/

Expand Down