Draft: ENH: Make dtypes immortal#30993
Open
eendebakpt wants to merge 3 commits into
Open
Conversation
Member
|
I think you need to add |
Contributor
Author
|
The header is included, but the symbol is not defined for python <= 3.12 |
Member
|
I guess it could make sense to make it a no-op on old versions. You'd have to check with victor though. |
Member
|
Oh, the other two places we have currently use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Make the numpy standard dtypes immortal to improve performance.
[benchmarks to be added]
@ngoldbaum
AI Disclosure
Claude was used to identify the correct location for
PyUnstable_SetImmortalto make the dtypes immortal.