Fix linter issues on main#425
Conversation
Signed-off-by: Or Mergi <ormergi@redhat.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses formatting inconsistencies that were causing the local 'make lint' command to fail on the main branch. The changes ensure that the codebase adheres to the expected style guidelines, improving consistency across the project. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Is this a BUG FIX or a FEATURE ?:
What this PR does / why we need it:
Running 'make lint' on local environment fail on main branch.
This PR resolve the linter issues.
Special notes for your reviewer:
Its not clear how the these un-formatted changes slipped in.
One gap I see is CI using golnagci-lint Github Action while for local development we have 'make lint'.
Although using linter GH Action continent the local development workflow may diverge, as in this case.
We should consider have CI run
make lintas well.Release note:
AI Guidelines Acknowledgment: