When I just tried this out, the plot dialog opened too small to fit all the new UI:

The plot legend gets a bit wonky with different line styles but I think it's probably OK:

I tend to think that this would make more sense as a global app preference rather than a per-rocket setting. Would be interested in hearing others' opinions.

Which plots I want to see depend on what I'm trying to figure out for a particular rocket. My guess is it's more useful as it is here.

When I just tried this out, the plot dialog opened too small to fit all the new UI:

I don't think that's a result of this PR. I've noticed it already several weeks before this PR. I haven't looked into fixing it yet.

I tend to think that this would make more sense as a global app preference rather than a per-rocket setting. Would be interested in hearing others' opinions.

I believe there are cases where you do want per-sim specific appearances, for instance if you want Plot A to use a solid line for altitude, but in Plot B a dashed line. But I also like the idea of a global app preference. Color-blind users could then customize the colors to their needs.

Would a "Set as default" button in the plot appearance row achieve the best of both worlds?

Would a "Set as default" button in the plot appearance row achieve the best of both worlds?

Probably, yeah. So in that case, when would you save the settings with the ORK file? Only when they're different from default?

@SiboVG do you want to add the "set as default" or should we merge it now?

Would a "Set as default" button in the plot appearance row achieve the best of both worlds?

Probably, yeah. So in that case, when would you save the settings with the ORK file? Only when they're different from default?

Yes, something like that.

@SiboVG do you want to add the "set as default" or should we merge it now?

I'll take a look at it this week.

Done. I added a "Set as default" and "Reset to factory default" button. To not clutter the UI, I used icon buttons (this SVG icon replacement is really paying off).

I do still want to change SwingPreferences to not use type.getName(), but type.getSaveKey(). But for that , #3109 needs to get merged first.

What are the tooltips on those two new buttons?

What are the tooltips on those two new buttons?

For set as default:

Set as default
Save the current color and line style as the application default for this data type

For reset to factory default:

Reset to factory default
Revert the color and line style to their built-in defaults for this plot

That sounds good. I'm not sure I'm totally on board with the choics of icons for those buttons, but that's a good enough starting point (the "save as default" button looks like a bookmark icon, which doesn't map to the function in my mind... is that a common usage?)

That sounds good. I'm not sure I'm totally on board with the choics of icons for those buttons, but that's a good enough starting point (the "save as default" button looks like a bookmark icon, which doesn't map to the function in my mind... is that a common usage?)

There really is no standard icon for this functionality. This is the closest I could find.