Eliminate "high speed deployment" warning in dual-deploy scenario #2670#3129
Eliminate "high speed deployment" warning in dual-deploy scenario #2670#3129thzero wants to merge 8 commits into
Conversation
|
I'll be testing this out tonight. Screenshots showing the affected UI would be helpful. |
…r options to not take up so much room
|
I haven't had a chance to try this out yet, but in the meantime one quick UI comment: please try to get the spacing within your "Recovery Speed Warnings" box the same as the others in the program. Your padding around the inside of the box (particularly, top and left) is too small. I have a suspicion that eventually more configurable warnings thresholds are going to be added and they will have to get bumped to a separate tab somehow, but I guess for now it makes sense for these to live in the Simulation Options tab the way you have them. |
Will look at that! |
Tweaked the UI to be consistent with padding and also where the editable fields are located. |
|
This looks like a great improvement to the deployment warnings. One question, is "Recovery speed warning" a drogue high speed warning? It should probably be labelled that more clearly. |
|
Thanks for the comments back.. let me work on some of those items.
I had pondered that too. I thought of some ways, but I'm thinking about saying on the recovery device a 'drogueless' option and/or on the simulator options too. I'm not quite sure what you mean by JLCR. I use both JLCRs as well as traditional altimeters for DD. You simply set the drogue for apogee, and you set the main parachute(s) for the altitude you expect them to deploy at. With JLCR its basically same but drogue comes out based on the ejection charge, main is set for your JLCR altitude. |
|
I still don't understand: what is "High speed deployment" if it isn't one of the other four? |
My apologies, you're correct, although my impression is that JLCRs are commonly used without drogues, so in those instances they would fit into the "drogueless" scenario.
Here's where I get a bit fuzzy on this. The "High Speed Deployment" warning is for single deployment scenarios. My impression (as an LPR flyer) has always been that the max deployment speed for mains on HPR are somewhat higher than for the typical apogee-deployed LPR parachutes, and that is what calls for a different threshold. Likewise, there is no "low speed deployment" warning in that situation. At present there is insufficient explanation in the dialog to make the user understand this. Even if there were, it's still messy and confusing... but I'm not sure how to fix it. @thzero, where did you get the threshold values that you put in there as defaults? Oh, one more issue: I was wondering if the "Drogue" checkbox should be moved higher up (like at the top of the deployment box). It'd be easy to not notice it where it is now. |
Well true, I guess I've seen both drogue and drogueless if I stop and think about it
Yup. I just got annoyed because I was having to explain to someone about it.
High end? Frankly from what I use - from mentors, HPR rocketry, etc. Current warning is 20ms, hardcoded. I normally use 100fps max for drogues. And 20fps for landing. |
|
What about the "low speed" thresholds? I was not aware that was even a thing. I thought first deploy was usually set at apogee, so deployment velocity of the drogue could be very low. |
Yes, unless you screw up and say delay for 5 seconds or something then it could be much higher. I.e. I often look at it, and say ok my backup charge is going to go off at 2 seconds after apogee, what speed is it at... |
|
It's true that main deployment speed for high power is nearly always higher than deployment speed for low power. All the same, I think it's less confusing to treat the low power single deployment as the main deployment for consistency. I've also never really heard of a deployment speed being too low, but at least for IREC we have a minimum speed at main deployment as we'll have occasional teams come through who are afraid enough of their recovery system that they want to bring the drogue down slower than the competition wants for the main. So I like the minimums for the selfish reason that it'll make reviewing them easier for me! The idea of having a high speed landing warning has come up periodically -- would this UI be a good place to configure it? |
|
Well I removed that anyway, it was too hard to explain and even I don't know that I really was using it. For normal usage, it works as it does today - bonus is that user can adjust instead of having a 20m/s. |
Maybe? You mean that if say your rocket lands at say 30fps, its probably needs a warning to be flagged? |
|
Ok, latest commit.
After a bunch of configuration options, and not trying to add/modify too much, I've ended up with the following Recovery Warning System.
Recovery Warning System — Per-Stage Dual/Single/Drogueless DetectionOverviewRecovery deployment speed warnings are evaluated per stage, independently, using the rocket's component configuration. Warning PathsEach stage gets one of three warning paths when a recovery device deploys:
Drogueless covers the case where a rocket freefalls or tumbles from apogee down to a lower deployment altitude, then deploys the main directly — no drogue chute is used to slow the descent. Because the rocket is in uncontrolled freefall until main deployment, a low-speed main warning doesn't apply (the main deploying too slowly is not a concern in this mode). How Detection WorksAt every recovery device deployment event, the engine:
The scan is scoped to the deploying stage so a drogue in stage 1 of a multi-stage rocket does not affect stage 2's warning thresholds. ConfigurationPer-device: "Is Drogue" checkbox (
|
| Threshold | Default | Used for |
|---|---|---|
RecoverySpeedWarning |
20 m/s | Single-deployment high-speed deploy |
RecoveryDrogueMainHighSpeedWarning |
30.48 m/s (100 fps) | Main deploy too fast (dual or drogueless) |
RecoveryDrogueMainLowSpeedWarning |
15.24 m/s (50 fps) | Main deploy too slow (dual only) |
|
Your latest description sounds better, sorry I'm a bit slow to get around to testing this. Will try to do so this weekend. I'm a bit concerned about the potentially conflicting "drogueless" and "this is a drogue" settings. I can't think of any other instance where component settings have been dependent on each other in this way (although I suppose the various "automatic" checkboxes are kind of like that). But I'll see how it looks when I try it out. Thanks for sticking with this one, it's tricky but should be valuable when finished. |
|
No problem. :) The other thing I was toying with is moving the 'is drogue' to Stage just like drogueless, but give them the option of selection a recovery device in a dropdown. Then that can just show in the recovery device, but that where there is one place to go to manage it per stage. |









Recovery Device Speed Warnings
Adds support for drogue-aware recovery speed warnings, giving dual-deploy fliers more relevant simulation feedback. This issue #2670.
Motivation
The existing high-speed deployment warning fires on every recovery device regardless of role. On a dual-deploy rocket, this means the drogue — which is intended to deploy at high speed — constantly triggers a false warning. This change allows a recovery device to be marked as a drogue, enabling warnings that are actually meaningful for dual-deploy configurations.
Changes
.orkfile format.