Add option to apply mirroring to the Y axis#21
Merged
Conversation
Collaborator
There was a problem hiding this comment.
Thanks for catering for the Gui part also with your latest commit to pcb2gcode
@vicencb
Is there a specific reason you are diverging from the established naming standard using:
mirroryaxis instead of mirroryaxisCheckBox ?
Contributor
Author
|
Hi Michael, Thanks for reviewing, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this change adds the option to appy the mirroring to the Y axis instead of the X axis.
It depends on the associated pull request on the CLI tool.
Regards,
Vicente.