add support for phpstan/phpdoc-parser 2#212
Merged
Merged
Conversation
25aa933 to
6e28db3
Compare
jaapio
requested changes
Nov 7, 2024
jaapio
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for your help to upgrade, I think we should accept the issues in the pipeline by adding the phpstan errors to the baseline. And add the missing symbol to the composer-require-checker config.
Let me know if you need any help with that.
9ee57f8 to
28b0f48
Compare
28b0f48 to
f421ef3
Compare
Contributor
Author
|
@jaapio thanks for the feedback, I guess this should be good now |
jaapio
approved these changes
Nov 9, 2024
Member
|
Merged and a new tag has been created. Thanks for your help |
Contributor
Author
|
Thank you for the fast release! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.