Add file and line context to "Unknown identifier" exceptions#14776
Open
iliaal wants to merge 1 commit into
Open
Add file and line context to "Unknown identifier" exceptions#14776iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
The three identifier collectors threw ShouldNotHappenException with a static "Unknown identifier" message (and a placeholder-less sprintf), so a rule passing a non-constant-string identifier aborted the whole extraction with no clue which file or call caused it. Include the analysed file and line in each message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ErrorWithIdentifierCollector,RuleErrorBuilderCollectorandRestrictedUsageCollectorthrewShouldNotHappenExceptionwith a static"Unknown identifier"message built by a placeholder-lesssprintf. When a rule passes a non-constant-string identifier the whole extraction aborts with no indication of which file or call caused it. Each message now includes the analysed file and line.php -lclean.