Add shared methods and build Shader() for p5.strands #8440#8880
Open
BHARATH0153 wants to merge 1 commit into
Open
Add shared methods and build Shader() for p5.strands #8440#8880BHARATH0153 wants to merge 1 commit into
BHARATH0153 wants to merge 1 commit into
Conversation
b747b5b to
8116e13
Compare
8116e13 to
83b4485
Compare
Author
|
@davepagurek @perminder-17 please review when you are free thanks! |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8440
overview
sharedFloat(), sharedVec2(), sharedVec3(), sharedVec4(), sharedInt(), sharedMat4(), and sharedBool() let users create varying variables to pass data between vertex and fragment shader hooks. They are used in other examples to pass data between hooks, but did not yet have their own reference pages.
Changes
src/webgl/p5.Shader.js: add shared* methods, varyings tracking in hooks, injection in shaderSrc(), preserve in modify() and copyToContext()
src/webgl/material.js: add buildColorShader, buildMaterialShader, buildNormalShader, buildStrokeShader, buildFilterShader, uniformTexture
PR Checklist