Make X509StoreContextError's message friendlier#1133
Merged
Conversation
Closes pyca#1132. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Member
Author
|
cc @reaperhulk for review! |
Signed-off-by: William Woodruff <william@trailofbits.com>
Member
|
This is backwards incompatible, so we should add it to the changelog and document it. |
Signed-off-by: William Woodruff <william@trailofbits.com>
Member
Author
|
Okay, updated the changelog. The exception class appears to be autodoc'd, so I don't think any doc changes are necessary. But let me know if I'm wrong. |
reaperhulk
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
messageis now a string, rather than a list of errors. The list of errors is separately preserved.Closes #1132.