gh-145854: Replace DELETE_NAME with PUSH_NULL; STORE_NAME#146006
Conversation
Changes - Removed `DELETE_NAME` - When `STORE_NAME` receives a `NULL` value, it corresponds with deletion
|
I am not sure why three of the CIFuzz tests fail. If anyone could help, that would be appreciated. |
|
This will need a magic number bump (as do all changes that add or remove opcodes) |
markshannon
left a comment
There was a problem hiding this comment.
Looks good. Thanks for doing this.
|
@markshannon A gentle reminder about this PR. |
There are merge conflicts. |
|
All commit authors signed the Contributor License Agreement. |
|
Sorry for leaving this sitting for so long. I notice that |
Documentation build overview
254 files changed ·
|
|
@markshannon A reminder about this PR, whenever you get a chance |
markshannon
left a comment
There was a problem hiding this comment.
Looks good. Thanks for doing this.
I mistake in the magic number comment and needs merge conflicts fixing.
Otherwise, good to merge.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Mark Shannon <Mark.Shannon@arm.com>
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
* main: (266 commits) pythongh-151626: Fix tests that fail when PYTHONPYCACHEPREFIX is set (pythonGH-151952) pythongh-152728: IDLE - move 3 toplevel fix_xyz functions to idlelb.util (python#152729) pythongh-152711: Add pythoninfo-build command to Platforms/Android (python#152713) pythongh-152715: Add pythoninfo-build command to Platforms/Apple (python#152716) pythongh-152433: Windows: enable mmapmodule for UWP (python#152473) pythongh-152433: Windows: use GetFileSizeEx instead of GetFileSize for memory mapped files (python#152383) pythonGH-81881: Raise `SpecialFileError` for sockets and devices in `shutil.copyfile` (python#142693) pythongh-152502: Detect the curses mouse interface and is_* methods portably (pythonGH-152705) pythongh-145857: Replace `DELETE_GLOBAL` with `PUSH_NULL; STORE_GLOBAL` (pythonGH-146314) pythongh-145854: Replace `DELETE_NAME` with `PUSH_NULL; STORE_NAME` (pythonGH-146006) pythongh-152680: Detect container/VM in test.pythoninfo (python#152668) pythongh-152682: Fix NULL dereference on OOM in `symtable_visit_type_param_bound_or_default` (python#152684) pythongh-151881: Skip tk_inactive negativity check on Windows (pythonGH-152683) pythongh-152546: Refactor `mappingproxy.__new__` to use `PyDictProxy_New` (python#152547) pythongh-151126: Fix a possible crash during the startup with no memory under `Py_STACKREF_DEBUG` (python#152478) pythongh-152635: Raise MemoryError when the lock allocation fails in `_interpchannels.create()` (python#152642) pythongh-151029: Fix `test_remote_exec_deleted_static_executable` on static installed builds (pythonGH-152653) pythongh-121249: Deprecate using F/D type codes in the struct module (python#152309) pythongh-152192: Fix JUMP_BACKWARD passing a truncated oparg to the jit tracer (pythonGH-152382) Don't require the `_test{internal}capi` modules in `test_monitoring.py` (python#152311) ...
Changes
DELETE_NAMESTORE_NAMEreceives aNULLvalue, it corresponds with deletionDELETE_NAMEinstruction #145854📚 Documentation preview 📚: https://cpython-previews--146006.org.readthedocs.build/