Skip to content

gh-152569: Fix asyncio.wait leaking tasks via await-graph on long-lived futures#152585

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
Skn0tt:gh-152569-wait-awaited-by-leak
Jul 2, 2026
Merged

gh-152569: Fix asyncio.wait leaking tasks via await-graph on long-lived futures#152585
kumaraditya303 merged 1 commit into
python:mainfrom
Skn0tt:gh-152569-wait-awaited-by-leak

Conversation

@Skn0tt

@Skn0tt Skn0tt commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

asyncio.wait registered the waiting task in each future's awaited_by set but only discarded it from completed futures, pinning the task on futures that never resolve. Discard from all futures on return.

Similar to fccbfc4.

@Skn0tt
pythongh-152569: Fix asyncio.wait leaking tasks via await-graph on lo…
5f8ef37 
…ng-lived futures

asyncio.wait registered the waiting task in each future's awaited_by set but only discarded it from completed futures, pinning the task on futures that never resolve. Discard from all futures on return.
@python-cla-bot

python-cla-bot Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request Jun 29, 2026
Closed
@kumaraditya303 kumaraditya303 merged commit f8514dc into python:main Jul 2, 2026
57 checks passed
@kumaraditya303 kumaraditya303 added topic-asyncio needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 2, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 2, 2026

Copy link
Copy Markdown

Thanks @Skn0tt for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-app Bot commented Jul 2, 2026

Copy link
Copy Markdown

Thanks @Skn0tt for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 2, 2026

Copy link
Copy Markdown

Thanks @Skn0tt for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app

bedevere-app Bot commented Jul 2, 2026

Copy link
Copy Markdown

GH-152866 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 2, 2026
@bedevere-app

bedevere-app Bot commented Jul 2, 2026

Copy link
Copy Markdown

GH-152867 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 2, 2026
@bedevere-app

bedevere-app Bot commented Jul 2, 2026

Copy link
Copy Markdown

GH-152868 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 2, 2026
@Skn0tt

Skn0tt commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the quick review!

@Skn0tt Skn0tt mentioned this pull request Jul 2, 2026
Closed
kumaraditya303 pushed a commit that referenced this pull request Jul 2, 2026
@miss-islington @Skn0tt
[3.14] gh-152569: Fix asyncio.wait leaking tasks via await-graph on l…
86e5a6e 
…ong-lived futures (GH-152585) (#152866)

gh-152569: Fix asyncio.wait leaking tasks via await-graph on long-lived futures (GH-152585)
(cherry picked from commit f8514dc)

Co-authored-by: Simon Knott <info@simonknott.de>
kumaraditya303 pushed a commit that referenced this pull request Jul 2, 2026
@miss-islington @Skn0tt
[3.15] gh-152569: Fix asyncio.wait leaking tasks via await-graph on l…
c2cb9bd 
…ong-lived futures (GH-152585) (#152868)

gh-152569: Fix asyncio.wait leaking tasks via await-graph on long-lived futures (GH-152585)
(cherry picked from commit f8514dc)

Co-authored-by: Simon Knott <info@simonknott.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Skn0tt @kumaraditya303