Skip to content

[3.7] bpo-36184: Port python-gdb.py to FreeBSD (GH-18873)#18882

Merged
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-6d0ee60-3.7
Mar 9, 2020
Merged

[3.7] bpo-36184: Port python-gdb.py to FreeBSD (GH-18873)#18882
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-6d0ee60-3.7

Conversation

@miss-islington

@miss-islington miss-islington commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

python-gdb.py now checks for "take_gil" function name to check if a
frame tries to acquire the GIL, instead of checking for
"pthread_cond_timedwait" which is specific to Linux and can be a
different condition than the GIL.
(cherry picked from commit 6d0ee60)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue36184

python-gdb.py now checks for "take_gil" function name to check if a
frame tries to acquire the GIL, instead of checking for
"pthread_cond_timedwait" which is specific to Linux and can be a
different condition than the GIL.
(cherry picked from commit 6d0ee60)

Co-authored-by: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 1695836 into python:3.7 Mar 9, 2020
@miss-islington miss-islington deleted the backport-6d0ee60-3.7 branch March 9, 2020 18:51
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants