Skip to content

Add versionchanged in create_datagram_endpoint doc#4697

Merged
asvetlov merged 2 commits into
python:masterfrom
romuald:create_datagram_endpoint-docfix
May 14, 2018
Merged

Add versionchanged in create_datagram_endpoint doc#4697
asvetlov merged 2 commits into
python:masterfrom
romuald:create_datagram_endpoint-docfix

Conversation

@romuald

@romuald romuald commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

Most of the parameters were added in 3.4.4 (b9bf913), but this
change was not documented

@romuald
Add versionchanged in create_datagram_endpoint doc
3668a7d 
Most of the parameters were added in 3.4.4 (b9bf913), but this
change was not documented
@romuald romuald requested a review from 1st1 as a code owner December 4, 2017 13:16
@asvetlov

asvetlov commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

Thanks for contribution but I think the ship has sailed too long ago for such change.
Pythons 3.4 and 3.5 are in security mode, no need to pollute docs with mentioning outdated versions.
Or, at least, it should be 3.5, not a number of bugfix release. For most asyncio users it doesn't matter.

@1st1 what is your opinion?

@romuald

romuald commented Dec 4, 2017

Copy link
Copy Markdown
Contributor Author

Note that in my case, I've just discovered this after deploying on a Debian jessie, that is still shipping with 3.4.2

@larryhastings

larryhastings commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

Documentation changes are always fine, even in security-fixes-only branches. I'll accept this in 3.4 and 3.5 after a review.

1st1
1st1 reviewed Dec 18, 2017
View reviewed changes
Comment thread Doc/library/asyncio-eventloop.rst Outdated

.. versionchanged:: 3.4.4

The *family*, *proto*, *flags*, *reuse_address*, *reuse_port, *allow_broadcast*, and *sock* parameters were added

@1st1 1st1 Dec 18, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break the line at 72 characters.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 docs Documentation in the Doc dir labels Mar 26, 2018
@asvetlov asvetlov merged commit 0ded580 into python:master May 14, 2018
@bedevere-bot

bedevere-bot commented May 14, 2018

Copy link
Copy Markdown

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented May 14, 2018

Copy link
Copy Markdown
Contributor

Thanks @romuald for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2018
@romuald @miss-islington
Add versionchanged in create_datagram_endpoint doc (pythonGH-4697)
ad4cb2e 
Most of the parameters were added in 3.4.4 (b9bf913), but this
change was not documented
(cherry picked from commit 0ded580)

Co-authored-by: Romuald Brunet <romuald@chivil.com>
@bedevere-bot

bedevere-bot commented May 14, 2018

Copy link
Copy Markdown

GH-6810 is a backport of this pull request to the 3.7 branch.

@asvetlov

asvetlov commented May 14, 2018

Copy link
Copy Markdown
Contributor

I've missed the PR, sorry

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2018
@romuald @miss-islington
Add versionchanged in create_datagram_endpoint doc (pythonGH-4697)
dc636c8 
Most of the parameters were added in 3.4.4 (b9bf913), but this
change was not documented
(cherry picked from commit 0ded580)

Co-authored-by: Romuald Brunet <romuald@chivil.com>
@bedevere-bot

bedevere-bot commented May 14, 2018

Copy link
Copy Markdown

GH-6811 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request May 14, 2018
@miss-islington @romuald
Add versionchanged in create_datagram_endpoint doc (GH-4697)
c6348cf 
Most of the parameters were added in 3.4.4 (b9bf913), but this
change was not documented
(cherry picked from commit 0ded580)

Co-authored-by: Romuald Brunet <romuald@chivil.com>
miss-islington added a commit that referenced this pull request May 14, 2018
@miss-islington @romuald
Add versionchanged in create_datagram_endpoint doc (GH-4697)
914bad6 
Most of the parameters were added in 3.4.4 (b9bf913), but this
change was not documented
(cherry picked from commit 0ded580)

Co-authored-by: Romuald Brunet <romuald@chivil.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 left review comments
@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@romuald @asvetlov @larryhastings @bedevere-bot @miss-islington @1st1 @serhiy-storchaka @the-knights-who-say-ni