Skip to content

bpo-32720: Fixed the replacement field grammar documentation.#5544

Merged
Mariatta merged 2 commits into
python:masterfrom
Mariatta:bpo-32720
Feb 5, 2018
Merged

bpo-32720: Fixed the replacement field grammar documentation.#5544
Mariatta merged 2 commits into
python:masterfrom
Mariatta:bpo-32720

Conversation

@Mariatta

@Mariatta Mariatta commented Feb 5, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

arg_name and element_index are defined as digit instead of integer.

https://bugs.python.org/issue32720

@Mariatta
bpo-32720: Fixed the replacement field grammar documentation.
9506ede 
`arg_name` and `element_index` are defined as `digit` instead of `integer`.
@Mariatta Mariatta added needs backport to 3.6 docs Documentation in the Doc dir labels Feb 5, 2018
nathankerr96
nathankerr96 suggested changes Feb 5, 2018
View reviewed changes

@nathankerr96 nathankerr96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these should be "digit+" since we can use one or more digits

@Mariatta

Mariatta commented Feb 5, 2018

Copy link
Copy Markdown
Member Author

@nathankerr96 Yes you're right :) Thanks. Updated.

@nathankerr96

nathankerr96 commented Feb 5, 2018

Copy link
Copy Markdown
Contributor

Great, thanks for making this change. I got caught up in the process of submitting my first pr and didn't do my due diligence. I should have caught this the first time around. Thanks again!

@Mariatta Mariatta merged commit 7a561af into python:master Feb 5, 2018
@miss-islington

miss-islington commented Feb 5, 2018

Copy link
Copy Markdown
Contributor

Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@Mariatta

Mariatta commented Feb 5, 2018

Copy link
Copy Markdown
Member Author

Thanks :)

@Mariatta Mariatta deleted the bpo-32720 branch February 5, 2018 09:29
@bedevere-bot

bedevere-bot commented Feb 5, 2018

Copy link
Copy Markdown

GH-5546 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2018
@Mariatta @miss-islington
bpo-32720: Fixed the replacement field grammar documentation. (python…
06be624 
…GH-5544)

`arg_name` and `element_index` are defined as `digit`+ instead of `integer`.
(cherry picked from commit 7a561af)

Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2018
@Mariatta @miss-islington
bpo-32720: Fixed the replacement field grammar documentation. (python…
9e2df04 
…GH-5544)

`arg_name` and `element_index` are defined as `digit`+ instead of `integer`.
(cherry picked from commit 7a561af)

Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Feb 5, 2018

Copy link
Copy Markdown

GH-5547 is a backport of this pull request to the 3.6 branch.

Mariatta added a commit that referenced this pull request Feb 7, 2018
@miss-islington @Mariatta
bpo-32720: Fixed the replacement field grammar documentation. (GH-5544)…
a747cf6 
… (GH-5546)

`arg_name` and `element_index` are defined as `digit`+ instead of `integer`.
(cherry picked from commit 7a561af)

Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Feb 12, 2018
@miss-islington @Mariatta
bpo-32720: Fixed the replacement field grammar documentation. (GH-5544)…
6708be7 
… (GH-5547)

`arg_name` and `element_index` are defined as `digit`+ instead of `integer`.
(cherry picked from commit 7a561af)

Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
+1 more reviewer
@nathankerr96 nathankerr96 nathankerr96 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mariatta @nathankerr96 @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni