Skip to content

travis: Use -O3 option#5599

Merged
methane merged 1 commit into
python:masterfrom
methane:travis-o3
Feb 10, 2018
Merged

travis: Use -O3 option#5599
methane merged 1 commit into
python:masterfrom
methane:travis-o3

Conversation

@methane

@methane methane commented Feb 9, 2018

Copy link
Copy Markdown
Member

We don't use debugger on Travis.

@methane
travis: Use -O3 option
35161d5 
We don't use debugger on Travis.
@methane

methane commented Feb 9, 2018

Copy link
Copy Markdown
Member Author

clang test is faster (about 18min -> 11min).
But no change on gcc+coverage test. It's surprising to me.

@JulienPalard

JulienPalard commented Feb 10, 2018

Copy link
Copy Markdown
Member

But no change on gcc+coverage test. It's surprising to me.

As travis has a cache and you did not changed any C file, make had nothing to do so it make sense the time didn't changed.

@methane methane merged commit 8ff5356 into python:master Feb 10, 2018
@methane methane deleted the travis-o3 branch February 10, 2018 11:35
@miss-islington

miss-islington commented Feb 10, 2018

Copy link
Copy Markdown
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Feb 10, 2018

Copy link
Copy Markdown
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Feb 10, 2018

Copy link
Copy Markdown
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Feb 10, 2018

Copy link
Copy Markdown
Contributor

Sorry, @methane, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8ff53564730f7ba503f5ad94418c309c48e8516d 3.6

@miss-islington

miss-islington commented Feb 10, 2018

Copy link
Copy Markdown
Contributor

Sorry, @methane, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8ff53564730f7ba503f5ad94418c309c48e8516d 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2018
@methane @miss-islington
travis: Use -O3 option (pythonGH-5599)
31004f5 
We don't use debugger on Travis.
(cherry picked from commit 8ff5356)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Feb 10, 2018

Copy link
Copy Markdown

GH-5607 is a backport of this pull request to the 3.7 branch.

methane added a commit that referenced this pull request Feb 10, 2018
@miss-islington @methane
travis: Use -O3 option (GH-5599)
e39429a 
We don't use debugger on Travis.
(cherry picked from commit 8ff5356)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
@serhiy-storchaka

serhiy-storchaka commented Apr 22, 2018

Copy link
Copy Markdown
Member

Do you mind to create backports to 3.6 and 2.7 @methane?

@methane

methane commented Apr 22, 2018 via email

Copy link
Copy Markdown
Member Author

methane added a commit to methane/cpython that referenced this pull request Apr 24, 2018
@methane
[3.6] travis: Use -O3 option (pythonGH-5599)
4cb7ebe 
We don't use debugger on Travis..
(cherry picked from commit 8ff5356)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
methane added a commit to methane/cpython that referenced this pull request Apr 24, 2018
@methane
[3.6] travis: Use -O3 option (pythonGH-5599)
b7309a8 
We don't use debugger on Travis..
(cherry picked from commit 8ff5356)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Apr 24, 2018

Copy link
Copy Markdown

GH-6590 is a backport of this pull request to the 3.6 branch.

@bedevere-bot

bedevere-bot commented Apr 24, 2018

Copy link
Copy Markdown

GH-6591 is a backport of this pull request to the 2.7 branch.

methane added a commit that referenced this pull request Apr 25, 2018
@methane
travis: Use -O3 option (GH-5599)
38e8936 
We don't use debugger on Travis..
(cherry picked from commit 8ff5356)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
methane added a commit that referenced this pull request Apr 25, 2018
@methane
travis: Use -O3 option (GH-5599)
730fb07 
We don't use debugger on Travis.
(cherry picked from commit 8ff5356)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@methane @JulienPalard @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni