bpo-33311: Do not display parameters displayed in parentheses for module call#6677
Merged
serhiy-storchaka merged 3 commits intoMay 9, 2018
Merged
bpo-33311: Do not display parameters displayed in parentheses for module call#6677serhiy-storchaka merged 3 commits into
serhiy-storchaka merged 3 commits into
Conversation
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
How hard to write tests for this?
| @@ -0,0 +1,2 @@ | |||
| Text and html output generated by cgitb does not display parentheses if the | |||
| current call is done directly in the module | |||
Member
There was a problem hiding this comment.
Missed period. Please add "Patch by yourname."
serhiy-storchaka
approved these changes
May 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the parentheses if the trace is in
moduledirectly.The parentheses and parameters are kept otherwise.
https://bugs.python.org/issue33311