Skip to content

Fix typo labeling PyUnicodeType's tp_basicsize field as "tp_size"#6775

Merged
zhangyangyu merged 1 commit into
python:masterfrom
mr-nfamous:patch-1
Jun 19, 2018
Merged

Fix typo labeling PyUnicodeType's tp_basicsize field as "tp_size"#6775
zhangyangyu merged 1 commit into
python:masterfrom
mr-nfamous:patch-1

Conversation

@mr-nfamous

Copy link
Copy Markdown
Contributor

Fixed the typo on line 15065 documenting PyUnicodeType.tp_basicsize as "tp_size" and realigned the comment labels.

Fixed the typo on line 15065 documenting PyUnicodeType.tp_basicsize as "tp_size" and realigned the comment labels.
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@zhangyangyu

Copy link
Copy Markdown
Member

Thanks @mr-nfamous . I merged your PR as an improvement. :-) Actually there are still some tp_size in other modules' comments. But I would suggest not to churn the codes in other modules since it doesn't do any harm and seems developers could identify what they mean. Thanks for your contribution. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants