bpo-34007: Skip traceback tests if the Program Counter is not available#9018
Merged
Conversation
Sometimes some versions of the shared libraries that are part of the traceback are compiled in optimised mode and the Program Counter (PC) is not present, not allowing gdb to walk the frames back. When this happens, the Python bindings of gdb raise an exception, making the test impossible to succeed.
vstinner
approved these changes
Aug 31, 2018
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
Let's see if the change fix the s390x buildbot. If yes, the change should be backported to other branches I guess.
Member
Author
|
@vstinner I will overlook the SLES s390x buildbots and backport if they are fixed. |
Member
Author
|
This works in the 3.x version of the buildbot: https://buildbot.python.org/all/#/builders/16/builds/1473 I will backport this to 3.7, 3.6 and 2.7. |
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7. |
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-9019 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 31, 2018
…le. (pythonGH-9018) Sometimes some versions of the shared libraries that are part of the traceback are compiled in optimised mode and the Program Counter (PC) is not present, not allowing gdb to walk the frames back. When this happens, the Python bindings of gdb raise an exception, making the test impossible to succeed. (cherry picked from commit f2ef51f) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 31, 2018
…le. (pythonGH-9018) Sometimes some versions of the shared libraries that are part of the traceback are compiled in optimised mode and the Program Counter (PC) is not present, not allowing gdb to walk the frames back. When this happens, the Python bindings of gdb raise an exception, making the test impossible to succeed. (cherry picked from commit f2ef51f) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
GH-9020 is a backport of this pull request to the 2.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 31, 2018
…le. (pythonGH-9018) Sometimes some versions of the shared libraries that are part of the traceback are compiled in optimised mode and the Program Counter (PC) is not present, not allowing gdb to walk the frames back. When this happens, the Python bindings of gdb raise an exception, making the test impossible to succeed. (cherry picked from commit f2ef51f) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
GH-9021 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Aug 31, 2018
…le. (GH-9018) Sometimes some versions of the shared libraries that are part of the traceback are compiled in optimised mode and the Program Counter (PC) is not present, not allowing gdb to walk the frames back. When this happens, the Python bindings of gdb raise an exception, making the test impossible to succeed. (cherry picked from commit f2ef51f) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Aug 31, 2018
…le. (GH-9018) Sometimes some versions of the shared libraries that are part of the traceback are compiled in optimised mode and the Program Counter (PC) is not present, not allowing gdb to walk the frames back. When this happens, the Python bindings of gdb raise an exception, making the test impossible to succeed. (cherry picked from commit f2ef51f) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Member
Thanks for fixing this buildbot! |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Sep 7, 2018
…vailable. (pythonGH-9018) Sometimes some versions of the shared libraries that are part of the traceback are compiled in optimised mode and the Program Counter (PC) is not present, not allowing gdb to walk the frames back. When this happens, the Python bindings of gdb raise an exception, making the test impossible to succeed. (cherry picked from commit f2ef51f) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes some versions of the shared libraries that are part of the
traceback are compiled in optimised mode and the Program Counter (PC)
is not present, not allowing gdb to walk the frames back. When this
happens, the Python bindings of gdb raise an exception, making the
test impossible to succeed.
https://bugs.python.org/issue34007