Fix deleting PTR records#360
Merged
Merged
Conversation
|
👍 |
Contributor
|
@cs278 Hey Chris, sorry about the delay in merging. Could you re-submit this to working branch, please? We don't merge straight to master unless it's a production release. |
jamiehannaford
pushed a commit
that referenced
this pull request
Jun 16, 2014
Fix deleting PTR records
Contributor
|
@cs278 Since I've just done a merge (for upcoming release) I'll merge this straight in. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting PTR records currently fails with a 404, this correctly sends the DELETE request to the collection rather than the individual entity.
Before:
After: