Hide repo-avatars for custom pages, like codespaces#9060
Closed
DarkIntaqt wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thank you, but that's not the right way to fix this issue. The proper approach would be to add
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom page "Create new Codespaces" seems to have the same DOM tree than a normal repository.
Therefore, the
repo-avatarsfeature tried to fetch an avatar for it.I added a denyList/set of "owners" that don't have avatars as they are GitHub special pages. Currently, I only found it on the Codespaces site, but I assume that there are more. The list is currently hardcoded.
Maybe, a more permanent solution would be to integrate a feature into
github-url-detectionin order to detect these special pages and not identify these as repositories.Test URLs
https://github.com/codespaces/new
https://github.com/refined-github/refined-github (nothing changed)
Screenshot
Before:
After:
