actionable-pr-view-file - Restore feature#9140
Conversation
|
If you pick this up, please just drop support for the old version. This is a rather invisible feature so I don't want to complicate things for it. |
Co-authored-by: Copilot <copilot@github.com>
|
WTF? I didn't use Copilot for these commits at all 
|
|
Sure, silently add Copilot to co-authors because I accepted the word "file" after "Renamed" without even paying attention. This is not annoying or stupid in the slightest 
|
we don't know when legacy pr files view will be removed or compare page will be rewritten
|
That's crazy 😂 |
Are you sure about that? Removing it won't simplify the code a lot: 30045da |
hmmm I guess it can stay. Up to you. |
| 'div[class^="DiffFileHeader-module__diff-file-header"] button:has(>.octicon-kebab-horizontal)', | ||
| 'click', | ||
| handleMenuOpening, | ||
| {signal}, |
There was a problem hiding this comment.
signal was missing
| $('[class^="prc-ActionList-ItemLabel"]', discardItem).textContent = 'Discard changes'; | ||
| $('[class^="prc-ActionList-LeadingVisual"]', discardItem).replaceChildren(<UndoIcon />); | ||
|
|
||
| editFile.after(discardItem); |
There was a problem hiding this comment.
I'd be more inclined to make these changes in a dedicated PR that also added a lint rule to no-restricted-syntax covering requestAnimationFrame(inline function
|
Finallyyyyyy |
|
This PR aged like wine 🍷 |
|
|
||
| function getFilePath(fileHeader: HTMLElement): string { | ||
| const fileNameElement = $('[class*="file-name"] code', fileHeader); | ||
| const renamedTooltip = $optional('span.sr-only', fileNameElement); |
There was a problem hiding this comment.
#8504
closes #8693
Test URLs
https://github.com/refined-github/sandbox/pull/4/changes?new_files_changed=true
Screenshot