For external contributors, I think it's important to know when a review comes from a member or from some rando who is reviewing your PR. I'm -0.5 on this change, I'd rather make the labels wrap correctly.

We can keep this PR open for a while to think about it though

Users browsing GitHub issues on an iPod Nano can benefit from this too:

Now they've enshittified this...

Fatter, less responsive, and much less convenient - you can't click on the element itself to unfold the thread anymore. Pure degradation.

I've changed the title because I wanted to extend this PR to cover ↑ this element too

Ready for re-review

Before
After

I never liked this component's look, I wonder if it can be improved further. Can be merged since it is definitely an improvement

So yeah the chevron and the "Show resolved" buttons do the same thing. I wonder if the latter is completely redundant and can be removed:

• threads start collapsed when they're resolved, so the status is implied
• the real status is already visible at the bottom once the thread is unfolded

So maybe this is enough:

> file/name.tsx (outdated)

The only drawback is that the chevron has a smaller hit area. Also I wonder if the chevron should be moved to the right side; the Files tab has chevron on the right side already.

I was thinking about hiding "show/hide resolved" as a part of a easy-toggle- feature

There's some overlap here, but I think that feature can (or should) operate without affecting the UI. The suggested change still makes sense as a CSS-only cleanup, especially if we move the chevron to the right.

I'd rather not further worsen the usability of an already nerfed element.

Also I wonder if the chevron should be moved to the right side; the Files tab has chevron on the right side already.

The chevron is always on the left. The comment (un-)collapse button is on the right.

• threads start collapsed when they're resolved, so the status is implied
• the real status is already visible at the bottom once the thread is unfolded

• That is only true when you first open the page, as unresolved review threads can also be collapsed.
• Threads can be long, and there can be a lot of them, which might make finding the status harder.

I've spent enough time on this element already, and I don't think there is room for improvement within the scope of a CSS-only bugfix. Can I merge this PR as is?

These two buttons with two different icons do the same things and it's alright for you?

The chevron is always on the left.

Indeed! So the more reasons to just drop the exact duplicate button that appears on the right and now bottom.

threads start collapsed

That is only true when you first open the page

That's what "start" meant. Why do you go around collapsing threads if they're not resolved? The difference is too small to care.

We could leave a (obsolete) (resolved) pill if we want to preserve the info, but then again this is the mobile view and you don't spent a long time curating the collapsible elements on the page, so collapsed ≈ resolved.

within the scope of a CSS-only bugfix

👍