toggle-everything-with-alt - Support "Resolve conversation"#9310
Merged
fregante merged 4 commits intoApr 30, 2026
Merged
Conversation
Alt-clicking a "Resolve conversation" or "Unresolve conversation" button in a PR conversation now applies the same action to every other thread in the same state, matching the rest of the feature's behavior on collapse togglers, suggestion-batching, etc. The selector keys off the form action (`/resolve` vs `/unresolve`) rather than the button label so it doesn't depend on visible text or i18n. Closes refined-github#9309
toggle-everything-with-alt: support "Resolve conversation"
Member
Can you include a demo video or gif? Untested AI PRs are not merged, the demo will tell us that you actually tested it |
toggle-everything-with-alt: support "Resolve conversation"toggle-everything-with-alt - Support "Resolve conversation"
Contributor
|
Note: The form is added to the DOM only after a hidden conversation is expanded. If you've just opened the page and want to bulk-unresolve comments, you won't be able to |
Member
|
Yeah this is kind of an issue with all the selections, they're all "best effort". For example |
Contributor
It's TanStack Virtual 🤓 |
Member
|
Tested 
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9309.
Alt-clicking a "Resolve conversation" or "Unresolve conversation" button in a PR conversation now applies the same action to every other thread in the same state, matching the rest of the feature's behavior on collapse togglers, suggestion-batching, etc.
The selector keys off the form action (
/resolvevs/unresolve) rather than the button label so it doesn't depend on visible text or i18n. The clicked button's parent form is used to decide which set to fan out to: alt-clicking Resolve resolves every other unresolved thread; alt-clicking Unresolve unresolves every other resolved thread.Test URLs
Screenshot
(Behavior is "click happens on every matching thread"; same fan-out as other handlers in this feature, no new visual surface.)
🤖 Authored with Claude Code