Skip to content

rgh-linkify-features rgh-feature-descriptions - Bug count#9370

Merged
fregante merged 27 commits into
mainfrom
copilot/add-open-issues-count-to-links
May 9, 2026
Merged

rgh-linkify-features rgh-feature-descriptions - Bug count#9370
fregante merged 27 commits into
mainfrom
copilot/add-open-issues-count-to-links

Conversation

Copilot AI commented May 7, 2026

Copy link
Copy Markdown
Contributor

Copilot AI changed the title [WIP] Add open issues count next to links in rgh-linkify-features Add open related-issues count next to rgh-linkify-features links May 7, 2026
Copilot AI requested a review from fregante May 7, 2026 06:02
@github-actions github-actions Bot added enhancement meta Related to Refined GitHub itself labels May 7, 2026

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still want the component to be a svelte component that is mounted every time. The component itself will have all the logic necessary to query and display the link, if necessary, or render nothing.

The component needs to accept props like 'include link' (whether to wrap in an a) and 'empty label' (defaults to nothing rendered when no issues are found, uses the provided string otherwise)

Comment thread source/helpers/rgh-related-issues-count.ts Outdated
Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
Comment thread source/helpers/rgh-links.tsx Outdated
…no loaded state, featureId required, linkify prop, no try/catch), mount via Svelte mount(), update callers

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/e0aeed91-9b96-4557-81b1-3b4619027ce8

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot

  • fix types
  • move sup element outside the component
  • change emptyLabel to single plural zero attributes, calling pluralize() internally

@fregante fregante marked this pull request as ready for review May 8, 2026 09:00

Copilot AI commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

@copilot remove the catch clause. Avoid the snippet pattern

Done in 3e82ea7 — removed {:catch} and replaced the {#snippet} with the {#if linkify} block inlined directly inside {:then}.

Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
Comment thread source/features/rgh-feature-descriptions.tsx Outdated
Comment thread source/features/rgh-feature-descriptions.tsx Outdated
Comment thread source/helpers/rgh-related-issues-count.svelte
Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
Comment thread source/features/rgh-linkify-features.tsx Outdated
Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
@fregante

fregante commented May 9, 2026

Copy link
Copy Markdown
Member

If you can, "start reviews" because the app makes it a pain to see multiple individual comments 😔

image

fregante and others added 5 commits May 9, 2026 08:31
Co-authored-by: Grigory <techuila.sunset@gmail.com>
Co-authored-by: Grigory <techuila.sunset@gmail.com>

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot make exclusively these changes, do not change anything else, don't move images

Comment thread source/features/rgh-feature-descriptions.tsx
Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
Comment thread source/helpers/rgh-related-issues-count.svelte Outdated
Copilot AI requested a review from fregante May 9, 2026 10:46
@fregante fregante enabled auto-merge (squash) May 9, 2026 10:49
@fregante fregante merged commit e795356 into main May 9, 2026
15 checks passed
@fregante fregante deleted the copilot/add-open-issues-count-to-links branch May 9, 2026 10:49
@fregante

fregante commented May 18, 2026

Copy link
Copy Markdown
Member

I love this little number so much. It immediately tells me how troublesome/active a feature is at any given time

Screenshot 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement meta Related to Refined GitHub itself

Development

Successfully merging this pull request may close these issues.

rgh-linkify-features - Add open issues count next to links

3 participants